[test] add typehints to create_block and create_coinbase
ClosedPublic
Actions

Authored by PiRK on Apr 8 2022, 08:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCed16e1d0000d: [test] add typehints to create_block and create_coinbase

Summary

These functions are hard to use without first looking at other tests, because the parameter types are not obvious. This improves the documentation and IDE hints for these functions.

Also remove a pair of redundant parentheses.

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 8 2022, 08:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2022, 08:29

PiRK requested review of this revision.Apr 8 2022, 08:29

PiRK retitled this revision from [test]add typehints to create_block and create_coinbase to [test] add typehints to create_block and create_coinbase.Apr 8 2022, 08:41

Harbormaster completed remote builds in B18758: Diff 33117.Apr 8 2022, 08:48

Fabien accepted this revision.Apr 8 2022, 09:20

This revision is now accepted and ready to land.Apr 8 2022, 09:20

Closed by commit rABCed16e1d0000d: [test] add typehints to create_block and create_coinbase (authored by PiRK). · Explain WhyApr 8 2022, 14:04

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCed16e1d0000d: [test] add typehints to create_block and create_coinbase.