Paths

Table of Contentst

Differential D11327

[Cashtab] Add mock API call to unit test
ClosedPublic
Actions

Authored by bytesofman on Apr 11 2022, 11:41.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC9f2ce665d2a8: [Cashtab] Add mock API call to unit test

Summary

T2393

Mock API call in unit test

Test Plan

Disable your internet connection
npm test and all pass

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 11 2022, 11:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2022, 11:41

bytesofman requested review of this revision.Apr 11 2022, 11:41

Harbormaster completed remote builds in B18772: Diff 33142.Apr 11 2022, 11:44

Add missing mock

Issue here is that the getRawTransaction call is not for the tx in question, but its first vin.

This is confusing for anyone coming into these unit tests who did not write them an hour or two ago.

Could be improved by splitting out every tx mock and giving it a name and variable.

bytesofman requested review of this revision.Apr 12 2022, 10:29

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B18792: Diff 33171.Apr 12 2022, 10:31

emack accepted this revision.Apr 13 2022, 10:04

This revision is now accepted and ready to land.Apr 13 2022, 10:04

Closed by commit rABC9f2ce665d2a8: [Cashtab] Add mock API call to unit test (authored by bytesofman). · Explain WhyApr 14 2022, 09:12

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC9f2ce665d2a8: [Cashtab] Add mock API call to unit test.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

__mocks__/

mockTxDataWithPassthrough.js

25 lines

__tests__/

useBCH.test.js

3 lines

Diff 33218

View Options

web/cashtab/src/hooks/mocks/mockTxDataWithPassthrough.js

View Options

web/cashtab/src/hooks/tests/useBCH.test.js

[Cashtab] Add mock API call to unit testClosedPublicActions