Paths

Table of Contentst

Differential D11337

rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset)
ClosedPublic
Actions

Authored by PiRK on Apr 12 2022, 13:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCae11b360f0f1: rpc: Properly document return values (submitblock, gettxout, getblocktemplate…

Summary

This is a backport of core#20556

Test Plan

src/bitcoin-cli help submitblock
src/bitcoin-cli help gettxout
src/bitcoin-cli help getblocktemplate
src/bitcoin-cli help scantxoutset

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 12 2022, 13:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2022, 13:55

PiRK requested review of this revision.Apr 12 2022, 13:55

teamcity edited the summary of this revision. (Show Details)Apr 12 2022, 13:55

Fix layout for strings split by the linter after indentation.
Improve test plan.

Harbormaster completed remote builds in B18795: Diff 33174.Apr 12 2022, 14:10

Harbormaster completed remote builds in B18796: Diff 33175.Apr 12 2022, 14:15

Fabien requested changes to this revision.Apr 12 2022, 20:38

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/rpc/blockchain.cpp
1366 ↗	(On Diff #33175)	Since you're touching it, you can as well update to `eCash address`
2735 ↗	(On Diff #33175)	That's wrong, it retuns only `progress`. Below is the doc when action=start

This revision now requires changes to proceed.Apr 12 2022, 20:38

replace "bitcoin address" with "eCash address"
Fix scantxoutset help ("When action=='start'" and "When action=='status' and scan is in progress"

Harbormaster completed remote builds in B18806: Diff 33193.Apr 13 2022, 07:23

Fabien accepted this revision.Apr 13 2022, 08:23

Fabien added inline comments.

src/rpc/blockchain.cpp
1365 ↗	(On Diff #33193)	Don't forget to update with a proper constant in D11343 (see my comment in the diff)

This revision is now accepted and ready to land.Apr 13 2022, 08:23

Closed by commit rABCae11b360f0f1: rpc: Properly document return values (submitblock, gettxout, getblocktemplate… (authored by PiRK). · Explain WhyApr 13 2022, 18:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCae11b360f0f1: rpc: Properly document return values (submitblock, gettxout, getblocktemplate….

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

154 lines

mining.cpp

232 lines

Diff 33212

View Options

src/rpc/blockchain.cpp