Page MenuHomePhabricator

rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset)
ClosedPublic

Authored by PiRK on Apr 12 2022, 13:55.

Details

Summary

This is a backport of core#20556

Test Plan
src/bitcoin-cli help submitblock
src/bitcoin-cli help gettxout
src/bitcoin-cli help getblocktemplate
src/bitcoin-cli help scantxoutset

Event Timeline

PiRK requested review of this revision.Apr 12 2022, 13:55
PiRK edited the test plan for this revision. (Show Details)

Fix layout for strings split by the linter after indentation.
Improve test plan.

Fabien requested changes to this revision.Apr 12 2022, 20:38
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
1366 ↗(On Diff #33175)

Since you're touching it, you can as well update to eCash address

2735 ↗(On Diff #33175)

That's wrong, it retuns only progress. Below is the doc when action=start

This revision now requires changes to proceed.Apr 12 2022, 20:38

replace "bitcoin address" with "eCash address"
Fix scantxoutset help ("When action=='start'" and "When action=='status' and scan is in progress"

Fabien added inline comments.
src/rpc/blockchain.cpp
1365

Don't forget to update with a proper constant in D11343 (see my comment in the diff)

This revision is now accepted and ready to land.Apr 13 2022, 08:23