Page MenuHomePhabricator
Differential D11341

[Cashtab] Delete contacts
ClosedPublic
Actions

Authored by emack on Apr 13 2022, 01:58.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC1d1f4a9d7a46: [Cashtab] Delete contacts
Summary

Supersedes D11324.

Contact deletion function.

Test Plan

Verify the Delete contact icon is not rendered in an empty contact list
Add a contact and ensure deletion via the confirmation modal is successful

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deleteContact2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18854
Build 37496: Build Diffcashtab-tests
Build 37495: arc lint + arc unit

Event Timeline

emack created this revision.Apr 13 2022, 01:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2022, 01:58
emack requested review of this revision.Apr 13 2022, 01:58
emack mentioned this in D11324: [Cashtab] Delete contacts.Apr 13 2022, 01:58
Harbormaster completed remote builds in B18802: Diff 33183.Apr 13 2022, 02:01
bytesofman requested changes to this revision.Apr 20 2022, 23:17

inline comment + rebase to latest master

web/cashtab/src/components/Configure/Configure.js
832 ↗(On Diff #33183)

Let's make this the contact name instead of the last 4 chars of the contact.

This revision now requires changes to proceed.Apr 20 2022, 23:17
emack updated this revision to Diff 33267.Apr 21 2022, 10:43
emack marked an inline comment as done.

Adjusted deletion confirmation to contact name and rebased to master

Harbormaster completed remote builds in B18854: Diff 33267.Apr 21 2022, 10:46
bytesofman accepted this revision.Apr 21 2022, 17:21
This revision is now accepted and ready to land.Apr 21 2022, 17:21
Closed by commit rABC1d1f4a9d7a46: [Cashtab] Delete contacts (authored by emack). · Explain WhyApr 21 2022, 22:48
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABC1d1f4a9d7a46: [Cashtab] Delete contacts.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Configure/
160 lines

Diff 33267

View Options

web/cashtab/src/components/Configure/Configure.js

Loading...