Differential D11344

[Cashtab] Rename contacts
ClosedPublic
Actions

Authored by emack on Apr 13 2022, 09:54.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC31a72674cb7b: [Cashtab] Rename contacts

Summary

Supersedes D11323. Rename contact function.

Test Plan

navigate to the Settings screen, open the contact list dropdown and verify the rename icon is not rendered for empty contact lists
send a tx to this wallet and then in the tx history click on the Add to contact link and ensure routing to the contact list dropdown
rename the contact and ensure the change in name persists even if the browser is restarted
rename the same contact multiple times and ensure the latest change is persisted

Diff Detail

Repository

rABC Bitcoin ABC

Branch

renameContact2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18808
Build 37407: Build Diff	cashtab-tests
Build 37406: arc lint + arc unit

Event Timeline

emack created this revision.Apr 13 2022, 09:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2022, 09:54

emack requested review of this revision.Apr 13 2022, 09:54

emack mentioned this in D11323: [Cashtab] Rename contacts.Apr 13 2022, 09:55

Harbormaster completed remote builds in B18808: Diff 33196.Apr 13 2022, 09:57

kieran709 accepted this revision.Apr 13 2022, 12:09

This revision is now accepted and ready to land.Apr 13 2022, 12:09

Closed by commit rABC31a72674cb7b: [Cashtab] Rename contacts (authored by emack). · Explain WhyApr 13 2022, 12:14

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC31a72674cb7b: [Cashtab] Rename contacts.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Configure/

130 lines

Diff 33196

web/cashtab/src/components/Configure/Configure.js

Loading...