Page MenuHomePhabricator

blockstorage: [refactor] Use chainman reference where possible
ClosedPublic

Authored by PiRK on Apr 13 2022, 13:11.

Details

Summary
Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Apr 13 2022, 13:11

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 13 2022, 13:43

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 25 2022, 13:23
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/blockstorage.cpp
41

revert

This revision is now accepted and ready to land.Apr 25 2022, 14:47
PiRK edited the summary of this revision. (Show Details)

restore blank line, remove comment about deleting blank line in summary