Differential D11356

[avalanche] Simplify the peermanager tests by factoring the buildProof lambdas
ClosedPublic
Actions

Authored by Fabien on Apr 13 2022, 22:24.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc11141b2fc04: [avalanche] Simplify the peermanager tests by factoring the buildProof lambdas

Summary

This turns the lambdas into a couple of static functions to reduce the code and have a single maintenance point. There is no change in behavior.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_buildproof_tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18822
Build 37434: Build Diff	build-diff · build-without-wallet · lint-circular-dependencies · build-clang · build-debug · build-clang-tidy
Build 37433: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 13 2022, 22:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2022, 22:24

Fabien requested review of this revision.Apr 13 2022, 22:24

Harbormaster completed remote builds in B18822: Diff 33216.Apr 13 2022, 22:41

PiRK accepted this revision.Apr 15 2022, 15:51

This revision is now accepted and ready to land.Apr 15 2022, 15:51

Closed by commit rABCc11141b2fc04: [avalanche] Simplify the peermanager tests by factoring the buildProof lambdas (authored by Fabien). · Explain WhyApr 15 2022, 20:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc11141b2fc04: [avalanche] Simplify the peermanager tests by factoring the buildProof lambdas.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

269 lines

Diff 33216

View Options

src/avalanche/test/peermanager_tests.cpp

[avalanche] Simplify the peermanager tests by factoring the buildProof lambdasClosedPublicActions