Differential D11362

Fix the util_tests.cpp build on OSX
ClosedPublic
Actions

Authored by Fabien on Apr 15 2022, 07:49.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc11a3542e8ee: Fix the util_tests.cpp build on OSX

Summary

The osx compiler is confused with the Amount multiplication operator. Should it be int or int64_t ? Let's hint the compiler with a good'ol cast.

Test Plan

On OSX:

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_osx_build

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18832
Build 37454: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-clang-tidy · build-debug · build-clang
Build 37453: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2022, 07:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2022, 07:49

Fabien requested review of this revision.Apr 15 2022, 07:49

@bot build-osx

teamcity awarded a token.Apr 15 2022, 07:50

Harbormaster completed remote builds in B18832: Diff 33229.Apr 15 2022, 08:05

PiRK accepted this revision.Apr 15 2022, 09:54

This revision is now accepted and ready to land.Apr 15 2022, 09:54

Closed by commit rABCc11a3542e8ee: Fix the util_tests.cpp build on OSX (authored by Fabien). · Explain WhyApr 15 2022, 10:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc11a3542e8ee: Fix the util_tests.cpp build on OSX.

Fabien mentioned this in D11374: Fix ambiguous amount multiplication.Apr 20 2022, 13:57

Fabien mentioned this in rABCabf382922243: Fix ambiguous amount multiplication.Apr 20 2022, 17:45

Revision Contents
Changeset List

Path

Size

src/

test/

util_tests.cpp

2 lines

Diff 33229

View Options

Fix the util_tests.cpp build on OSXClosedPublicActions