Page MenuHomePhabricator
Differential D11366

[avalanche] Introduce a Proof::ToHex() shortcut
ClosedPublic
Actions

Authored by Fabien on Apr 15 2022, 12:26.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC6e6d363b551c: [avalanche] Introduce a Proof::ToHex() shortcut
Summary

As per title. There is currently a couple call sites but more will be added. There is no change in behavior (extensively tested via the RPC).

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 15 2022, 12:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2022, 12:26
Fabien requested review of this revision.Apr 15 2022, 12:26
Fabien planned changes to this revision.Apr 15 2022, 12:30

One more callsite to add

Fabien updated this revision to Diff 33235.Apr 15 2022, 12:34

Add one missing callsite

Fabien edited the summary of this revision. (Show Details)Apr 15 2022, 12:35
Harbormaster completed remote builds in B18836: Diff 33234.Apr 15 2022, 12:41
Fabien retitled this revision from [avalanche] Introduce a Proof::ToHex() shorcut to [avalanche] Introduce a Proof::ToHex() shortcut.Apr 15 2022, 12:41
Harbormaster completed remote builds in B18837: Diff 33235.Apr 15 2022, 12:50
Fabien added a child revision: D11367: [avalanche] Account for our own proof in the connected stake computation.Apr 15 2022, 13:33
PiRK accepted this revision.Apr 15 2022, 15:47
This revision is now accepted and ready to land.Apr 15 2022, 15:47
Closed by commit rABC6e6d363b551c: [avalanche] Introduce a Proof::ToHex() shortcut (authored by Fabien). · Explain WhyApr 15 2022, 20:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6e6d363b551c: [avalanche] Introduce a Proof::ToHex() shortcut.

Revision Contents
Changeset List

PathSize
src/
avalanche/
1 line
6 lines
rpc/
9 lines

Diff 33241

View Options

src/avalanche/proof.h

Loading...
View Options

src/avalanche/proof.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...