Ability to add a wallet in the Saved Wallets dropdown to the contact list.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCb1b735eb8594: [Cashtab] Add a saved wallet to contact list
- npm start
- open the saved wallets dropdown and click on the Contact icon, and then the OK button in the confirmation modal and verify wallet is successfully added to contacts
- attempt to add the same saved wallet and verify duplication notification is displayed with no change to the contact list
- change the name of this same saved wallet, attempt to add it from the saved wallet dropdown again and ensure the same duplication notification is displayed
- change the name of the contact for this same saved wallet, attempt to add it from the saved wallet dropdown again and ensure the same duplication notification is displayed
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- savedWalletContacts
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18917 Build 37614: Build Diff cashtab-tests Build 37613: arc lint + arc unit
Event Timeline
Comment Actions
pulling this back for a minor update - spotted a bug where adding a duplicate contact address from saved wallets correctly results in the duplication error but it does not clear the manual name/address state variables. This creates a downstream issue if the user then chooses to manually add a new contact, which contains the previous duplicate inputs and the user is forced to edit the name/address input fields before validation for the OK button passes.