bench: use the node context & chain from the TestSetup instead of creating a new one
ClosedPublic
Actions

Authored by PiRK on May 5 2022, 19:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC286e3a4ebe96: bench: use the node context & chain from the TestSetup instead of creating a…

Summary

I missed this change when backporting core#19425 in D11419. It caused an assertion to fail when running this benchmark:

bitcoin-bench: ../../src/interfaces/chain.cpp:226: interfaces::{anonymous}::ChainImpl::findBlock(const BlockHash&, const interfaces::FoundBlock&)::<lambda()>: Assertion `"m_node.chainman" &&check' failed.

Link to original Bitcoin Core commit

Test Plan

ninja bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 5 2022, 19:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2022, 19:18

PiRK requested review of this revision.May 5 2022, 19:18

teamcity edited the summary of this revision. (Show Details)May 5 2022, 19:18

@bot build-bench

teamcity awarded a token.May 5 2022, 19:19

PiRK edited the summary of this revision. (Show Details)May 5 2022, 19:22

PiRK edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B18967: Diff 33426.May 5 2022, 19:39

Fabien accepted this revision.May 5 2022, 20:16

This revision is now accepted and ready to land.May 5 2022, 20:16

Closed by commit rABC286e3a4ebe96: bench: use the node context & chain from the TestSetup instead of creating a… (authored by PiRK). · Explain WhyMay 6 2022, 06:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC286e3a4ebe96: bench: use the node context & chain from the TestSetup instead of creating a….

Revision Contents
Changeset List

Path

Size

src/

bench/

wallet_balance.cpp

9 lines

Diff 33431

View Options

src/bench/wallet_balance.cpp

bench: use the node context & chain from the TestSetup instead of creating a new oneClosedPublicActions