Page MenuHomePhabricator
Differential D11419

refactor: Replace uses ChainActive() in interfaces/chain.cpp
ClosedPublic
Actions

Authored by PiRK on May 5 2022, 14:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5780de4ba17d: refactor: Replace uses ChainActive() in interfaces/chain.cpp
Summary

This is a backport of core#19425 [2/3]
https://github.com/bitcoin/bitcoin/pull/19425/commits/6965f1352d2d7086d308750ce83a84f191a17755

Depends on D11418

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 5 2022, 14:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2022, 14:55
PiRK requested review of this revision.May 5 2022, 14:55
teamcity edited the summary of this revision. (Show Details)May 5 2022, 14:56
PiRK added a child revision: D11420: test: Remove no longer needed MakeChain calls.May 5 2022, 15:00
Harbormaster completed remote builds in B18952: Diff 33404.May 5 2022, 15:17
Fabien accepted this revision.May 5 2022, 15:54
This revision is now accepted and ready to land.May 5 2022, 15:54
Closed by commit rABC5780de4ba17d: refactor: Replace uses ChainActive() in interfaces/chain.cpp (authored by PiRK). · Explain WhyMay 5 2022, 16:42
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5780de4ba17d: refactor: Replace uses ChainActive() in interfaces/chain.cpp.
PiRK mentioned this in D11430: bench: use the node context & chain from the TestSetup instead of creating a new one.May 5 2022, 19:18
PiRK mentioned this in rABC286e3a4ebe96: bench: use the node context & chain from the TestSetup instead of creating a….May 6 2022, 06:20
PiRK mentioned this in D11751: refactor: Replace uses ChainActive() in interfaces/chain.cpp (follow-up).Jul 15 2022, 08:15
PiRK mentioned this in rABCde05c8ddedd6: refactor: Replace uses ChainActive() in interfaces/chain.cpp (follow-up).Jul 15 2022, 10:45

Revision Contents
Changeset List

PathSize
src/
interfaces/
52 lines
test/
12 lines
wallet/
test/
52 lines

Diff 33414

View Options

src/interfaces/chain.cpp

Loading...
View Options

src/test/interfaces_tests.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...