Page MenuHomePhabricator
Differential D11425

node/ifaces: ChainImpl: Use existing NodeContext member
ClosedPublic
Actions

Authored by PiRK on May 5 2022, 16:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbea681fd0daa: node/ifaces: ChainImpl: Use existing NodeContext member
Summary

This is a backport of core#21270 [9/12] and core#21525 [10/10]
https://github.com/bitcoin/bitcoin/pull/21270/commits/91c5b68acd12cf7c2b4888d54d8fdd21837b2817
https://github.com/bitcoin/bitcoin/pull/21525/commits/693414d27181cf967f787a2ca72344e52c58c7f0

Depends on D11424

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 5 2022, 16:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2022, 16:33
PiRK requested review of this revision.May 5 2022, 16:33
teamcity edited the summary of this revision. (Show Details)May 5 2022, 16:33
Harbormaster completed remote builds in B18959: Diff 33412.May 5 2022, 16:54
Fabien requested changes to this revision.May 6 2022, 10:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/chain.cpp
223 ↗(On Diff #33412)

This block is missing the chainman() update, which appears to also be missing in the PR. Can you check if you're missing a commit ?

254 ↗(On Diff #33412)

Same

271 ↗(On Diff #33412)

That's duplicated

274 ↗(On Diff #33412)

Same

293 ↗(On Diff #33412)

Duplicated as well

295 ↗(On Diff #33412)

Same

This revision now requires changes to proceed.May 6 2022, 10:02
PiRK updated this revision to Diff 33436.May 6 2022, 13:15

deduplicate assertions

I checked on the current master, and the chainman() accessor is still only used for the 3 instances introduced in https://github.com/bitcoin/bitcoin/pull/21525/commits/693414d27181cf967f787a2ca72344e52c58c7f0
There is no missing dependency, AFAIK.

Harbormaster completed remote builds in B18972: Diff 33436.May 6 2022, 13:29
Fabien accepted this revision.May 6 2022, 14:39
This revision is now accepted and ready to land.May 6 2022, 14:39
Closed by commit rABCbea681fd0daa: node/ifaces: ChainImpl: Use existing NodeContext member (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMay 9 2022, 06:54
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCbea681fd0daa: node/ifaces: ChainImpl: Use existing NodeContext member.

Revision Contents
Changeset List

PathSize
src/
interfaces/
50 lines

Diff 33449

View Options

src/interfaces/chain.cpp

Loading...