Page MenuHomePhabricator

node/ifaces: ChainImpl: Use existing NodeContext member
ClosedPublic

Authored by PiRK on May 5 2022, 16:33.

Event Timeline

PiRK requested review of this revision.May 5 2022, 16:33
Fabien requested changes to this revision.May 6 2022, 10:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/chain.cpp
223 ↗(On Diff #33412)

This block is missing the chainman() update, which appears to also be missing in the PR. Can you check if you're missing a commit ?

254 ↗(On Diff #33412)

Same

271 ↗(On Diff #33412)

That's duplicated

274 ↗(On Diff #33412)

Same

293 ↗(On Diff #33412)

Duplicated as well

295 ↗(On Diff #33412)

Same

This revision now requires changes to proceed.May 6 2022, 10:02

deduplicate assertions

I checked on the current master, and the chainman() accessor is still only used for the 3 instances introduced in https://github.com/bitcoin/bitcoin/pull/21525/commits/693414d27181cf967f787a2ca72344e52c58c7f0
There is no missing dependency, AFAIK.

This revision is now accepted and ready to land.May 6 2022, 14:39