test: Misc cleanup for p2p_blockfilters
ClosedPublic
Actions

Authored by PiRK on May 11 2022, 10:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2addcd8036c6: test: Misc cleanup for p2p_blockfilters

Summary

Replace wait_until with assert_equal where possible
Use send_and_ping helper where possible

This is a backport of core#22311 [3/4]
https://github.com/bitcoin/bitcoin/pull/22311/commits/faa211fc6e3d4984b8edff1d762dd4cba205d982

Depends on D11444

Test Plan

test/functional/test_runner.py p2p_blockfilters

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 11 2022, 10:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2022, 10:33

PiRK requested review of this revision.May 11 2022, 10:33

teamcity edited the summary of this revision. (Show Details)May 11 2022, 10:33

PiRK added a child revision: D11446: test: Add missing syncwithvalidationinterfacequeue.May 11 2022, 10:35

Harbormaster completed remote builds in B18996: Diff 33473.May 11 2022, 10:51

Fabien accepted this revision.May 11 2022, 11:10

This revision is now accepted and ready to land.May 11 2022, 11:10

Closed by commit rABC2addcd8036c6: test: Misc cleanup for p2p_blockfilters (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMay 11 2022, 11:45

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2addcd8036c6: test: Misc cleanup for p2p_blockfilters.

PiRK added a child revision: D11486: txorphanage: Extract GetOrphanTx.May 18 2022, 08:30

PiRK removed a child revision: D11486: txorphanage: Extract GetOrphanTx.May 18 2022, 08:30

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_blockfilters.py

13 lines

Diff 33477

View Options

test/functional/p2p_blockfilters.py

test: Misc cleanup for p2p_blockfiltersClosedPublicActions