Differential D11500

[avalanche] Add some tests to check that duplicate votes are not counted
ClosedPublic
Actions

Authored by sdulfari on May 19 2022, 18:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC767e5c7a8044: [avalanche] Add some tests to check that duplicate votes are not counted

Summary

Every change we make to vote accounting risks breaking vote deduping.
This patch adds some test coverage to reduce that risk since I plan on doing
just that.

Depends on D11499

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

dedup-votes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19112
Build 37972: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 37971: arc lint + arc unit

Event Timeline

sdulfari created this revision.May 19 2022, 18:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2022, 18:09

sdulfari requested review of this revision.May 19 2022, 18:09

Harbormaster completed remote builds in B19112: Diff 33627.May 19 2022, 18:26

sdulfari added a child revision: D11501: [avalanche] Remove unnecessary code path in addNodeToQuorum.May 19 2022, 18:28

Fabien accepted this revision.May 20 2022, 09:28

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/test/voterecord_tests.cpp
155

This revision is now accepted and ready to land.May 20 2022, 09:28

Added finalization sanity check

sdulfari added inline comments.May 20 2022, 16:29

src/avalanche/test/voterecord_tests.cpp
155	I tried to make this work, but the side effects do not appear to happen in the way we expect with BOOST_CHECK_EQUAL. I added a sanity check for finalization at the end of this test instead.