Page MenuHomePhabricator

[avalanche] Set voterecord_tests node ID using a fixture
ClosedPublic

Authored by sdulfari on May 19 2022, 23:40.

Details

Summary

This puts shared init code for each test in a common fixture and clarifies some naming.

Depends on D11502

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.May 20 2022, 09:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/test/voterecord_tests.cpp
13 ↗(On Diff #33636)

You don't need the TestingSetup at all, just replace it

This revision now requires changes to proceed.May 20 2022, 09:57
  • Rebase on changes in D11502
  • Remove TestingSetup. It's not needed.
This revision is now accepted and ready to land.May 23 2022, 08:06