Page MenuHomePhabricator
Differential D11505

miner: Add chainstate member to BlockAssembler
ClosedPublic
Actions

Authored by PiRK on May 20 2022, 10:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCeb05628f0139: miner: Add chainstate member to BlockAssembler
Summary

This is a partial backport of core#21525

Revert commits (rABCd1b32162feaf))
https://github.com/bitcoin/bitcoin/pull/21525/commits/0c1b2bc549aec77b247f0103652d883227841ac5
https://github.com/bitcoin/bitcoin/pull/21525/commits/eede0647b06b6009080c4e536a2705e911d6ee19
https://github.com/bitcoin/bitcoin/pull/21525/commits/e62067e7bcad5a559899afff2e4a8e8b7e9f4301

Refactor commit
https://github.com/bitcoin/bitcoin/pull/21525/commits/7b8e976cd5ac78a22f1be2b2fed8562c693af5d9

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 20 2022, 10:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2022, 10:55
PiRK requested review of this revision.May 20 2022, 10:55
teamcity edited the summary of this revision. (Show Details)May 20 2022, 10:55
Harbormaster completed remote builds in B19117: Diff 33638.May 20 2022, 11:13
PiRK planned changes to this revision.May 20 2022, 15:20

squash with D11504 to avoid intermediary regression in globalness of chain state.

PiRK updated this revision to Diff 33648.May 20 2022, 16:37
PiRK edited the summary of this revision. (Show Details)

squash D11505 with D11504

Harbormaster completed remote builds in B19126: Diff 33648.May 20 2022, 16:51
PiRK removed a parent revision: D11504: Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock".May 20 2022, 16:55
PiRK mentioned this in D11504: Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock".May 23 2022, 12:11
Fabien accepted this revision.May 23 2022, 12:28
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/mining.cpp
427 ↗(On Diff #33648)

Revert or make it consistent

This revision is now accepted and ready to land.May 23 2022, 12:28
Closed by commit rABCeb05628f0139: miner: Add chainstate member to BlockAssembler (authored by PiRK). · Explain WhyMay 23 2022, 15:49
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCeb05628f0139: miner: Add chainstate member to BlockAssembler.

Revision Contents
Changeset List

PathSize
src/
10 lines
25 lines
rpc/
13 lines
test/
4 lines
62 lines
util/
4 lines
4 lines
5 lines

Diff 33670

View Options

src/miner.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/test/blockfilter_index_tests.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/util/mining.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/test/validation_block_tests.cpp

Loading...