Page MenuHomePhabricator

Move the DifferenceFormatter to serialize.h
ClosedPublic

Authored by Fabien on May 23 2022, 15:35.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC83f1192427f4: Move the DifferenceFormatter to serialize.h
Summary

This formatter will be used for the compact proofs as well. Also added some unit tests.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 23 2022, 15:35
PiRK added a subscriber: PiRK.

Thanks for adding the documentation.

This revision is now accepted and ready to land.May 23 2022, 16:07
Fabien planned changes to this revision.May 23 2022, 18:24
Fabien added inline comments.
src/test/serialize_tests.cpp
487 ↗(On Diff #33669)

need to remove the magic number (it is overflow)

Removing missed magic number

This revision is now accepted and ready to land.May 23 2022, 18:45
This revision was automatically updated to reflect the committed changes.