HomePhabricator

Fix off by one errors in the difference fomatter serialize_tests

Description

Fix off by one errors in the difference fomatter serialize_tests

Summary:
One of the overflow test added in D11515 is not doing what is expected, due to a couple errors:

  • the MAX_SIZE value is a compact size difference value, so the indexes should increment by MAX_SIZE+1
  • the loop size if off by one

Test Plan:

ninja check-bitcoin-serialize_tests

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Subscribers: sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D11567

Details

Provenance
FabienAuthored on Jun 3 2022, 18:56
FabienPushed on Jun 3 2022, 21:26
Reviewer
Restricted Project
Differential Revision
D11567: Fix off by one errors in the difference fomatter serialize_tests
Parents
rABCb6b66a36334e: [Cashtab] Run npm test before commit
Branches
Unknown
Tags
Unknown