Related to T2411. Add Contact and Export Contacts buttons have been modified, icons added and positioning has been changed.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC57dbf02e5987: [Cashtab] Button labeling & positioning in Contact List patch
cd web/cashtab && npm start
navigate to the settings tab
expand the Contact List collapse
observe that:
Export Contacts and New Contact buttons have been changed to readDownload CSV & Add Contact
Icons have been added
Buttons are positioned next to each other
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- contact-list-button-labeling
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19208 Build 38164: Build Diff cashtab-tests Build 38163: arc lint + arc unit
Event Timeline
Comment Actions
Looks good!
In other buttons, we use a standard of icon first, then label (left to right). Please match that here.
Comment Actions
Hide the word "Download" at the device width where stacking begins, so that both buttons maintain the same height.
| web/cashtab/src/components/Configure/Configure.js | ||
|---|---|---|
| 358 ↗ | (On Diff #33748) | We don't want this applied to every span on the Configure.js screen. Maybe now there happens to be no other ones, so it's okay. But it should be more specific. Create a specific styled component span to use this rule and only apply it to these buttons. |
Comment Actions
Applied device width rule directly to styled span instead of through the button component, changed Button to Btn for consistency.