Differential D11545

[avalanche] Request missing proofs from short ids
ClosedPublic
Actions

Authored by Fabien on May 31 2022, 12:44.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC041c5b4699c1: [avalanche] Request missing proofs from short ids

Summary

This diff introduce a new avaproofsreq message to request the missing proofs from a peer in response to a compact proofs message.

Depends on D11549 and D11571.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_avaproofs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19299
Build 38339: Build Diff	lint-circular-dependencies · build-diff · build-clang-tidy · build-without-wallet · build-clang · build-debug
Build 38338: arc lint + arc unit

Event Timeline

Fabien created this revision.May 31 2022, 12:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2022, 12:44

Fabien requested review of this revision.May 31 2022, 12:44

Harbormaster completed remote builds in B19198: Diff 33745.May 31 2022, 13:00

Use a hidden flag to bypass the anti dos in test rather than a dedicated network permission

Fabien edited the summary of this revision. (Show Details)May 31 2022, 14:10

Fabien removed a parent revision: D11544: [avalanche] Add network permission for a peer to send unrequested compact proofs.

Harbormaster completed remote builds in B19200: Diff 33747.May 31 2022, 14:26

deadalnix requested changes to this revision.May 31 2022, 16:32

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/init.cpp
397 ↗	(On Diff #33747)	Why would you send and/or accept unsolicited compatcproofs messages? Just solicit them.

This revision now requires changes to proceed.May 31 2022, 16:32

Rebase on top of D11549 to actually request the compact proofs

Fabien edited the summary of this revision. (Show Details)Jun 1 2022, 10:02

Fabien added a parent revision: D11549: [avalanche] Request compact proofs from our avalanche outbound peers.

Fabien removed a parent revision: D11533: [avalanche] Extract the compact proofs functional test to its own file.

Harbormaster completed remote builds in B19212: Diff 33763.Jun 1 2022, 10:18

Remove unnecessary timeout

Harbormaster completed remote builds in B19213: Diff 33764.Jun 1 2022, 13:18

deadalnix requested changes to this revision.Jun 1 2022, 15:41

deadalnix added inline comments.

src/net_processing.cpp
5169 ↗	(On Diff #33764)	Shouldn't this require some kind of lock?
5249 ↗	(On Diff #33764)	I assume most of this code is duplicated. You made design choices to have similar design between compact block and compact proofs, so you should be leveraging this and share the code.

This revision now requires changes to proceed.Jun 1 2022, 15:41

Fabien planned changes to this revision.Jun 1 2022, 16:01

Fabien added inline comments.

src/net_processing.cpp
5169 ↗	(On Diff #33764)	Not at this stage, this is always accessed within the same thread, but I can make it an atomic to avoid silent issues if an RPC is added that calls this code
5249 ↗	(On Diff #33764)	yes, there are some differences but most is common, I'll see what I can factorize

Fabien mentioned this in D11549: [avalanche] Request compact proofs from our avalanche outbound peers.Jun 2 2022, 09:23

Rebase on top of D11571 to share most of the code with compact blocks

Fabien edited the summary of this revision. (Show Details)Jun 4 2022, 01:13

Fabien added a parent revision: D11571: Extract the compact block processing into a generic helper class.

Harbormaster completed remote builds in B19259: Diff 33821.Jun 4 2022, 01:35

Store the radix tree as nullable in the node data

Bail out if proof relay is not enabled

Harbormaster completed remote builds in B19260: Diff 33822.Jun 6 2022, 10:48

Harbormaster completed remote builds in B19261: Diff 33823.

Rebase, use calculate_shortid in the functional test (see D11573)

Harbormaster completed remote builds in B19282: Diff 33856.Jun 7 2022, 09:55

Fabien added a child revision: D11575: [avalanche] Respond to missing proof indices request.Jun 7 2022, 12:49

deadalnix requested changes to this revision.Jun 7 2022, 22:49

deadalnix added inline comments.

src/net.h
658 ↗	(On Diff #33856)	Stop wrapping that tree in a smart pointer. I don't know why you want to do that, just don't. If there is a problem fix it.

This revision now requires changes to proceed.Jun 7 2022, 22:49

Unwrap the tree

Fabien planned changes to this revision.Jun 8 2022, 08:30

Harbormaster completed remote builds in B19299: Diff 33888.Jun 8 2022, 08:43

Fabien requested review of this revision.Jun 8 2022, 09:13

deadalnix accepted this revision.Jun 8 2022, 22:38

This revision is now accepted and ready to land.Jun 8 2022, 22:38

Closed by commit rABC041c5b4699c1: [avalanche] Request missing proofs from short ids (authored by Fabien). · Explain WhyJun 9 2022, 07:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC041c5b4699c1: [avalanche] Request missing proofs from short ids.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

compactproofs.h

29 lines

net_processing.cpp

95 lines

6 lines

1 line

test/

functional/

abc_p2p_compactproofs.py

175 lines

test_framework/

35 lines

4 lines

Diff 33888

src/avalanche/compactproofs.h

Loading...

src/net_processing.cpp

Loading...

src/protocol.h

Loading...

src/protocol.cpp

Loading...

test/functional/abc_p2p_compactproofs.py

Loading...

test/functional/test_framework/messages.py

Loading...

test/functional/test_framework/p2p.py

Loading...