Differential D11559

[Cashtab] Copy own address from Sign Message collapse in Send.js
ClosedPublic
Actions

Authored by kieran709 on Jun 2 2022, 15:36.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCe2dd146417da: [Cashtab] Copy own address from Sign Message collapse in Send.js

Summary

Related to T2362. Part of the user's request was to add the ability to copy one's own address from the Sign Message collapse in Send.js.

Test Plan

cd web/cashtab && npm start
navigate to send screen
expand the Sign Message collapse
click on the Addres input
observe that current wallet's address is copied to clipboard
observe the copy success notification

Diff Detail

Repository

rABC Bitcoin ABC

Branch

copy-own-address-from-sign-message-collapse

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19237
Build 38221: Build Diff	cashtab-tests
Build 38220: arc lint + arc unit

Event Timeline

kieran709 created this revision.Jun 2 2022, 15:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2022, 15:36

kieran709 requested review of this revision.Jun 2 2022, 15:36

Harbormaster completed remote builds in B19237: Diff 33792.Jun 2 2022, 15:39

It's not intuitive that clicking the address will copy it to the clipboard. Use the standard copy paste icon. I think it would be best if this was in-line with the input form.

This revision now requires changes to proceed.Jun 2 2022, 17:16

Responding to review feedback.

Harbormaster completed remote builds in B19240: Diff 33797.Jun 2 2022, 20:14

Looks great. Please rebase to latest master before landing.

This revision is now accepted and ready to land.Jun 3 2022, 21:40

Closed by commit rABCe2dd146417da: [Cashtab] Copy own address from Sign Message collapse in Send.js (authored by kieran709). · Explain WhyJun 6 2022, 19:55

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCe2dd146417da: [Cashtab] Copy own address from Sign Message collapse in Send.js.