Paths

Table of Contentst

Differential D11593

[Cashtab] Patch API error handling
ClosedPublic
Actions

Authored by bytesofman on Jun 8 2022, 23:24.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC3665cf037c18: [Cashtab] Patch API error handling

Summary

T2491

Add missing console.log statement to API call function
Add type check to result of function to catch network errors

Test Plan

npm start
confirm this error is not thrown with normal API

Diff Detail

Repository

rABC Bitcoin ABC

Branch

api-error-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19315
Build 38369: Build Diff	cashtab-tests
Build 38368: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 8 2022, 23:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2022, 23:24

bytesofman requested review of this revision.Jun 8 2022, 23:24

Harbormaster completed remote builds in B19315: Diff 33909.Jun 8 2022, 23:27

emack accepted this revision.Jun 9 2022, 02:31

This revision is now accepted and ready to land.Jun 9 2022, 02:31

Closed by commit rABC3665cf037c18: [Cashtab] Patch API error handling (authored by bytesofman). · Explain WhyJun 9 2022, 02:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC3665cf037c18: [Cashtab] Patch API error handling.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useBCH.js

1 line

useWallet.js

8 lines

Diff 33909

View Options

web/cashtab/src/hooks/useBCH.js