[avalanche] Deduplicate registration time for peers
AbandonedPublic
Actions

Authored by Fabien on Jun 17 2022, 15:40.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

The peer registration time and the proof registration time are identical, this diff removes the peer registration time and use the newly introduced proof registration time instead. There is no change in behavior.

Depends on D11634.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_move_registrationtime

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19410
Build 38553: Build Diff	lint-circular-dependencies · build-debug · build-clang · build-without-wallet · build-clang-tidy · build-diff
Build 38552: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 17 2022, 15:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2022, 15:40

Fabien requested review of this revision.Jun 17 2022, 15:40

Fabien added a child revision: D11636: [avalanche] Simplify the proof counting in ProofPool.Jun 17 2022, 15:45

Harbormaster completed remote builds in B19404: Diff 34041.Jun 17 2022, 15:59

sdulfari requested changes to this revision.Jun 17 2022, 17:15

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

src/avalanche/peermanager.cpp
505 ↗	(On Diff #34041)	unused?
src/net_processing.cpp
2631 ↗	(On Diff #34041)	This casting logic should be pushed to the getProofRegistrationTime API (see https://reviews.bitcoinabc.org/D11634#inline-52544)