Page MenuHomePhabricator

[avalanche] Deduplicate registration time for peers
AbandonedPublic

Authored by Fabien on Jun 17 2022, 15:40.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Summary

The peer registration time and the proof registration time are identical, this diff removes the peer registration time and use the newly introduced proof registration time instead. There is no change in behavior.

Depends on D11634.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_move_registrationtime
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19404
Build 38541: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 38540: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jun 17 2022, 15:40
sdulfari requested changes to this revision.Jun 17 2022, 17:15
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/avalanche/peermanager.cpp
505

unused?

src/net_processing.cpp
2631

This casting logic should be pushed to the getProofRegistrationTime API (see https://reviews.bitcoinabc.org/D11634#inline-52544)

This revision now requires changes to proceed.Jun 17 2022, 17:15

Update API and remove unused var

This revision is now accepted and ready to land.Jun 20 2022, 16:21
Fabien planned changes to this revision.Jun 22 2022, 20:12