Page MenuHomePhabricator
Differential D1163

Various nits in wallet.py
ClosedPublic
Actions

Authored by deadalnix on Mar 5 2018, 13:44.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING205a9d12e0cd: Various nits in wallet.py
rABC205a9d12e0cd: Various nits in wallet.py
Summary

As per title.

Depends on D1162

Test Plan
./test/functional/test_runner.py wallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wallettestnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1987
Build 2123: Bitcoin ABC Buildbot (legacy)
Build 2122: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 5 2018, 13:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2018, 13:44
teamcity added a subscriber: teamcity.Mar 5 2018, 13:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1987: Diff 3062.Mar 5 2018, 14:10
teamcity added a comment.Mar 5 2018, 14:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix updated this revision to Diff 3067.Mar 5 2018, 14:32

Add wallet-dump

deadalnix updated this revision to Diff 3068.Mar 5 2018, 14:35

Remove wallet-dump which was added by mistake

teamcity added a comment.Mar 5 2018, 14:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 5 2018, 14:54

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 5 2018, 15:13

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1992: Diff 3067.Mar 5 2018, 15:13
teamcity added a comment.Mar 5 2018, 15:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1993: Diff 3068.Mar 5 2018, 15:16
schancel requested changes to this revision.Mar 5 2018, 18:09
schancel added a subscriber: schancel.
schancel added inline comments.
test/functional/wallet.py
290 ↗(On Diff #3068)

broadcastet. If we're going to fix this, we should fix it.

This revision now requires changes to proceed.Mar 5 2018, 18:09
deadalnix updated this revision to Diff 3079.Mar 5 2018, 18:32

broadcastet -> broadcasted

teamcity added a comment.Mar 5 2018, 20:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 5 2018, 21:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1999: Diff 3079.Mar 5 2018, 21:14
schancel accepted this revision.Mar 5 2018, 22:07
This revision is now accepted and ready to land.Mar 5 2018, 22:07
Closed by commit rABC205a9d12e0cd: Various nits in wallet.py (authored by deadalnix). · Explain WhyMar 6 2018, 08:58
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
61 lines

Diff 3062

View Options

test/functional/wallet.py

Loading...