Page MenuHomePhabricator
Differential D11650

miner_tests: pass chainman and active_chainstate to helper functions
ClosedPublic
Actions

Authored by PiRK on Jun 21 2022, 08:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC645dcc26aba7: miner_tests: pass chainman and active_chainstate to helper functions
Summary

This removes usage of global chainstate for Bitcoin ABC specific code.
Also make the functions static.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 21 2022, 08:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2022, 08:42
PiRK requested review of this revision.Jun 21 2022, 08:42
PiRK added a child revision: D11651: scripted-diff: test: Use existing chainman in unit tests.Jun 21 2022, 08:44
PiRK retitled this revision from pass NodeContext to helper functions to miner_tests: pass NodeContext to helper functions.Jun 21 2022, 08:44
Harbormaster completed remote builds in B19430: Diff 34073.Jun 21 2022, 09:20
Fabien requested changes to this revision.Jun 21 2022, 11:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/miner_tests.cpp
226 ↗(On Diff #34073)

Don't pass the whole node context when all you need is the chain manager and the mempool. This is more robust because you don't have to assume that they are non null.

This revision now requires changes to proceed.Jun 21 2022, 11:01
PiRK updated this revision to Diff 34076.Jun 21 2022, 13:39
PiRK retitled this revision from miner_tests: pass NodeContext to helper functions to miner_tests: pass chainman and active_chainstate to helper functions.

don't pass the whole context, pass only the required subobjects

Harbormaster completed remote builds in B19433: Diff 34076.Jun 21 2022, 13:52
Fabien accepted this revision.Jun 21 2022, 14:08
This revision is now accepted and ready to land.Jun 21 2022, 14:08
Closed by commit rABC645dcc26aba7: miner_tests: pass chainman and active_chainstate to helper functions (authored by PiRK). · Explain WhyJun 22 2022, 07:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC645dcc26aba7: miner_tests: pass chainman and active_chainstate to helper functions.

Revision Contents
Changeset List

PathSize
src/
test/
63 lines

Diff 34089

View Options

src/test/miner_tests.cpp

Loading...