tests: trivial simplification in pad_tx
ClosedPublic
Actions

Authored by PiRK on Jun 23 2022, 07:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa43b1b63fcd4: tests: trivial simplification in pad_tx

Summary

There is no need to initialize an empty list to just append to it unconditionaly only once.

Note that this function has a dedicated unitest, so this change is tested extensively.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

simplify_pad_tx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19449
Build 38631: Build Diff	build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 38630: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 23 2022, 07:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 23 2022, 07:19

PiRK requested review of this revision.Jun 23 2022, 07:19

Harbormaster completed remote builds in B19449: Diff 34101.Jun 23 2022, 07:35

Fabien accepted this revision.Jun 23 2022, 08:00

This revision is now accepted and ready to land.Jun 23 2022, 08:00

Closed by commit rABCa43b1b63fcd4: tests: trivial simplification in pad_tx (authored by PiRK). · Explain WhyJun 24 2022, 08:40

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa43b1b63fcd4: tests: trivial simplification in pad_tx.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

txtools.py

9 lines

Diff 34101

View Options

test/functional/test_framework/txtools.py

tests: trivial simplification in pad_txClosedPublicActions