Page MenuHomePhabricator

[avalanche] Run the proofs cleanup on a schedule
ClosedPublic

Authored by Fabien on Jun 24 2022, 15:38.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCd9578a9219ed: [avalanche] Run the proofs cleanup on a schedule
Summary

This diffs runs the dangling proofs cleanup every 5 minutes and add tests for it.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 24 2022, 15:38
sdulfari requested changes to this revision.Jun 24 2022, 19:43
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/avalanche/peermanager.h
229 ↗(On Diff #34128)

Unused?

test/functional/abc_feature_proof_cleanup.py
29 ↗(On Diff #34128)

I recently landed D11622 so you'll probably need to add '-avaproofstakeutxoconfirmations=1',

This revision now requires changes to proceed.Jun 24 2022, 19:43
src/avalanche/peermanager.h
229 ↗(On Diff #34128)

Good catch, leftover from another code

  • Rebase, update the funcional test accordingly and run it with --nolegacyavaproof
  • Remove leftover
  • Remove spurious ; in the peermanager unit test
This revision is now accepted and ready to land.Jun 24 2022, 20:54