Paths

Table of Contentst

Differential D11685

tree-wide: Remove stray review-only assertion
ClosedPublic
Actions

Authored by PiRK on Jun 29 2022, 10:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7e8275e964af: tree-wide: Remove stray review-only assertion

Summary

Unfortunately, these assertion don't fit the regex in the scripted-diff.
Therefore, we remove it manually

This is a backport of core#21866 [9/12]
https://github.com/bitcoin/bitcoin/pull/21866/commits/3e82abb8dd7e21ec918966105648be7ae077fd8c

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19505
Build 38740: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 38739: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 29 2022, 10:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2022, 10:19

PiRK requested review of this revision.Jun 29 2022, 10:19

teamcity edited the summary of this revision. (Show Details)Jun 29 2022, 10:20

PiRK added a child revision: D11686: scripted-diff: tree-wide: Remove all review-only assertions.Jun 29 2022, 10:22

Harbormaster completed remote builds in B19505: Diff 34177.Jun 29 2022, 10:55

Fabien accepted this revision.Jun 29 2022, 19:05

This revision is now accepted and ready to land.Jun 29 2022, 19:05

Closed by commit rABC7e8275e964af: tree-wide: Remove stray review-only assertion (authored by PiRK). · Explain WhyJun 30 2022, 09:02

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7e8275e964af: tree-wide: Remove stray review-only assertion.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.cpp

12 lines

node.cpp

24 lines

Diff 34177

View Options

src/interfaces/chain.cpp