Page MenuHomePhabricator
Differential D11688

[Chronik] Install nightly rust toolchain dependency (as "abc-nightly")
ClosedPublic
Actions

Authored by tobias_ruck on Jun 29 2022, 23:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC781c46dcdd64: [Chronik] Install nightly rust toolchain dependency (as "abc-nightly")
Summary

Install nightly-2022-06-29 in install-dependencies.sh

This allows us to use the unstable features of rustfmt, most importantly --skip-children, which gives us similar behavior to the other linters.

We name it "abc-nightly", and invoke it by adding +abc-nightly to commands.

Test Plan
  1. docker run -i -t bitcoinabc/bitcoin-abc-dev
  2. Paste the lines in the diff
  3. $RUST_HOME/rustc +abc-nightly --version outputs rustc 1.64.0-nightly (830880640 2022-06-28)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Jun 29 2022, 23:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2022, 23:20
tobias_ruck requested review of this revision.Jun 29 2022, 23:20
Harbormaster completed remote builds in B19512: Diff 34186.Jun 29 2022, 23:21
Fabien requested changes to this revision.Jul 1 2022, 11:53
Fabien added inline comments.
contrib/utils/install-dependencies.sh
145 ↗(On Diff #34186)
147 ↗(On Diff #34186)
This revision now requires changes to proceed.Jul 1 2022, 11:53
tobias_ruck updated this revision to Diff 34208.Jul 1 2022, 15:31

Use ${} and ""

Harbormaster completed remote builds in B19525: Diff 34208.Jul 1 2022, 15:31
Fabien accepted this revision.Jul 1 2022, 16:56
This revision is now accepted and ready to land.Jul 1 2022, 16:56
Closed by commit rABC781c46dcdd64: [Chronik] Install nightly rust toolchain dependency (as "abc-nightly") (authored by tobias_ruck). · Explain WhyJul 1 2022, 17:33
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC781c46dcdd64: [Chronik] Install nightly rust toolchain dependency (as "abc-nightly").

Revision Contents
Changeset List

PathSize
contrib/
utils/
7 lines

Diff 34212

View Options

contrib/utils/install-dependencies.sh

Loading...