Related to task T2519 & T2415. Airdrops are now parsed in Tx history, including an Airdrop icon, token icon, and token name.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
cd web/cashtab && npm start
navigate to wallet home
if there are no airdrop txs, send and receive and airdrop
observe that airdrop txs now include an airdrop icon, text indicating that the tx is an airdrop, the token icon and token name associated with the airdrop.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- parse-airdrops-in-txHistory
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19517 Build 38764: Build Diff cashtab-tests Build 38763: arc lint + arc unit
Event Timeline
| web/cashtab/src/components/Home/Tx.js | ||
|---|---|---|
| 371 | While this approach "works" -- it's not the best way forward. This will require multiple API calls every time the app loads. Instead, we want to follow the token info approach used for eToken txs. In this approach, the token info is added to the tx data object when the tx history is batch processed. Then it is stored in cache, making future API calls unnecessary. You'll need to modify some functions to get the tokenInfo available in the data object that comes in as a prop to this component. Start with addTokenTxDataToSingleTx in useBCH.js. Let me know if you have any questions. | |
| 447 | should not be using className anywhere in the app except where it is unavoidable. Is there an open task to remove className from this component? If not, please create. | |