Differential D11698

[avalanche] Don't clean up the proof radix tree when it's already null
AbandonedPublic
Actions

Authored by Fabien on Jul 4 2022, 08:10.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Summary

The periodic cleanup will reset the copy of the radix tree even if the tree is already null, printing unnecessary log info that causes confusion. This diff checks there is something to clean before processing which prevents the log from outputting misleading information when the remote already requested the missing indices, so the tree has already been cleaned up.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_send_empty_avareq

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19539
Build 38797: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 38796: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 4 2022, 08:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2022, 08:10

Fabien requested review of this revision.Jul 4 2022, 08:10

Fabien edited the summary of this revision. (Show Details)Jul 4 2022, 08:17

Fabien edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B19539: Diff 34228.Jul 4 2022, 08:26

You are creating special cases where none is necessary. Just handle the zero proof case like any other case is handled.

This revision now requires changes to proceed.Jul 5 2022, 12:49

Fabien mentioned this in D11721: [avalanche] Get rid of the compact proof cleanup log.Jul 6 2022, 13:30

Fabien mentioned this in rABC9c5bc52366a6: [avalanche] Get rid of the compact proof cleanup log.Jul 8 2022, 09:51

Fabien abandoned this revision.Jul 27 2022, 12:00

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

1 line

7 lines

test/

radix_tests.cpp

46 lines

test/

functional/

abc_p2p_compactproofs.py

6 lines

Diff 34228

src/net_processing.cpp

Loading...

src/radix.h

Loading...

src/test/radix_tests.cpp

Loading...

test/functional/abc_p2p_compactproofs.py

Loading...