Page MenuHomePhabricator

[avalanche] Don't clean up the proof radix tree when it's already null
AbandonedPublic

Authored by Fabien on Jul 4 2022, 08:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

The periodic cleanup will reset the copy of the radix tree even if the tree is already null, printing unnecessary log info that causes confusion. This diff checks there is something to clean before processing which prevents the log from outputting misleading information when the remote already requested the missing indices, so the tree has already been cleaned up.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_send_empty_avareq
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19539
Build 38797: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 38796: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jul 4 2022, 08:10
Fabien edited the summary of this revision. (Show Details)
deadalnix requested changes to this revision.Jul 5 2022, 12:49
deadalnix added a subscriber: deadalnix.

You are creating special cases where none is necessary. Just handle the zero proof case like any other case is handled.

This revision now requires changes to proceed.Jul 5 2022, 12:49