Page MenuHomePhabricator
Differential D11706

[Chronik] Add clippy linter as build target
ClosedPublic
Actions

Authored by tobias_ruck on Jul 4 2022, 19:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC023ec18fb65e: [Chronik] Add clippy linter as build target
Summary

cargo clippy catches common mistakes and improves the Rust code.

  1. Refactor: Add add_cargo_custom_target function to invoke a cargo command as custom target.
  2. Rename check-bitcoinsuite to check-bitcoinsuite-test to test bitcoinsuite crates.
  3. Add check-bitcoinsuite-clippy to lint bitcoinsuite crates.
  4. Add check-bitcoinsuite custom target that has the above two as dependencies.
Test Plan
  1. ninja check-bitcoinsuite runs cargo clippy and cargo test successfully.
  2. Adding pub struct X; at the end of chronik/bitcoinsuite-core/src/lib.rs, then running ninja check-bitcoinsuite makes the build fail.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-clippy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19547
Build 38813: Build Diff
Build 38812: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jul 4 2022, 19:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2022, 19:49
tobias_ruck requested review of this revision.Jul 4 2022, 19:49
Harbormaster completed remote builds in B19547: Diff 34236.Jul 4 2022, 19:49
tobias_ruck updated this revision to Diff 34241.Jul 4 2022, 21:31

Fix indentation, add CARGO_BUILD_DIR to clean files.

Harbormaster completed remote builds in B19551: Diff 34241.Jul 4 2022, 21:31
Fabien requested changes to this revision.Jul 5 2022, 07:43
Fabien added inline comments.
chronik/CMakeLists.txt
18 ↗(On Diff #34241)

Do you plan to add more parameters ? Otherwise you can just use ARGN directly, and make it a macro

46 ↗(On Diff #34241)

This can be integrated into the add_cargo_custom_target facility

This revision now requires changes to proceed.Jul 5 2022, 07:43
tobias_ruck updated this revision to Diff 34248.Jul 5 2022, 14:31

Refactor: add add_crate_test_targets; intended to be used for chronik- crates later

Harbormaster completed remote builds in B19557: Diff 34248.Jul 5 2022, 14:31
Fabien accepted this revision.Jul 5 2022, 14:33
This revision is now accepted and ready to land.Jul 5 2022, 14:33
Closed by commit rABC023ec18fb65e: [Chronik] Add clippy linter as build target (authored by tobias_ruck). · Explain WhyJul 5 2022, 14:35
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC023ec18fb65e: [Chronik] Add clippy linter as build target.

Revision Contents
Changeset List

PathSize
chronik/
27 lines
bitcoinsuite-core/
src/
25 lines

Diff 34236

View Options

chronik/CMakeLists.txt

Loading...
View Options

chronik/bitcoinsuite-core/src/lib.rs

Loading...