Page MenuHomePhabricator
Differential D11753

validation: Farewell, global Chainstate!
ClosedPublic
Actions

Authored by PiRK on Jul 15 2022, 08:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf78286b329af: validation: Farewell, global Chainstate!
Summary

This concludes backport of core#21866 [12/12]
https://github.com/bitcoin/bitcoin/pull/21866/commits/6f994882deafe62e97f0a889d8bdb8c96dcf913d

Depends on D11752

Backport note: the changes in qt/test/apptests.cpp are done in a different commit in the source material, but this is incorrect and belongs here (as explained in D11752)

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 15 2022, 08:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2022, 08:33
PiRK requested review of this revision.Jul 15 2022, 08:33
teamcity edited the summary of this revision. (Show Details)Jul 15 2022, 08:34
PiRK planned changes to this revision.Jul 15 2022, 08:45
Harbormaster completed remote builds in B19643: Diff 34381.Jul 15 2022, 08:54
PiRK mentioned this in D11752: qt/test: Reset chainman in ~ChainstateManager instead.Jul 15 2022, 09:23
PiRK updated this revision to Diff 34383.Jul 15 2022, 09:27
PiRK edited the summary of this revision. (Show Details)

include the change in src/qt/test/apptests.cpp that Core incorrectly included in the previous commit (D11752)

Harbormaster completed remote builds in B19645: Diff 34383.Jul 15 2022, 09:47
Fabien accepted this revision.Jul 15 2022, 09:49
This revision is now accepted and ready to land.Jul 15 2022, 09:49
Closed by commit rABCf78286b329af: validation: Farewell, global Chainstate! (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJul 15 2022, 10:45
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABC3151d3637eac: qt/test: Reset chainman in ~ChainstateManager instead.
PiRK added a commit: rABCf78286b329af: validation: Farewell, global Chainstate!.

Revision Contents
Changeset List

PathSize
src/
6 lines
node/
3 lines
1 line
qt/
test/
5 lines
2 lines
test/
util/
4 lines
16 lines
13 lines

Diff 34391

View Options

src/init.cpp

Loading...
View Options

src/node/context.h

Loading...
View Options

src/node/context.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...