The quorum is considered valid if we got connected to enough nodes and
got some specific messages from them, but if the count drops (due to
node disconnect) we might fall below the minimum number required for
getting a convergent vote, and keep polling. This diff makes the quorum
invalid if the node has less than 8 avalanche nodes connected.
Details
Details
- Reviewers
sdulfari - Group Reviewers
Restricted Project - Commits
- rABCb86f8a391c2c: [avalanche] Don't consider our quorum valid if we don't have enough nodes…
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/avalanche/test/processor_tests.cpp | ||
|---|---|---|
| 1355 ↗ | (On Diff #34413) | This parameter is still latched, if you were connected to 80% of the stakes and get a new proof that you don't know the node yet you don't want to have a bad quorum and get flip-floping |
Comment Actions
The code changes are fine, but the comments (or lack of) confuse the intent.
| src/avalanche/processor.cpp | ||
|---|---|---|
| 678 ↗ | (On Diff #34413) | This needs a comment why we short circuit before checking the latch. |
| 679 ↗ | (On Diff #34413) | This comment conflates this function call with polling. While mostly true, it's also used in periodic networking. |