Page MenuHomePhabricator

locks and docs in ATMP and CheckInputsFromMempoolAndCache
ClosedPublic

Authored by PiRK on Jul 19 2022, 13:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9b904d85f5a3: locks and docs in ATMP and CheckInputsFromMempoolAndCache
Summary

This is a very small PR that adds some lock annotations to clarify that, now, the pool.cs lock is held throughout tx validation for mempool. The comments in CheckInputsFromMempoolAndCache were unclear/outdated so I updated those as well.

This is a backport of core#20834

Notes: the PolicyScriptChecks and CheckFeeRate methods don't exist in our codebase, they are part of PreChecks. See D8203.

Test Plan

With clang and debug:
ninja all check-all

With clang and TSAN:
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jul 19 2022, 13:49
Fabien requested changes to this revision.Jul 19 2022, 14:29
Fabien added a subscriber: Fabien.

The test plan doesn't cover the changes

This revision now requires changes to proceed.Jul 19 2022, 14:29
PiRK requested review of this revision.Jul 20 2022, 09:17
PiRK edited the test plan for this revision. (Show Details)

Test plan updated with TSAN

This revision is now accepted and ready to land.Jul 20 2022, 15:28