HomePhabricator

locks and docs in ATMP and CheckInputsFromMempoolAndCache

Description

locks and docs in ATMP and CheckInputsFromMempoolAndCache

Summary:

This is a very small PR that adds some lock annotations to clarify that, now, the pool.cs lock is held throughout tx validation for mempool. The comments in CheckInputsFromMempoolAndCache were unclear/outdated so I updated those as well.

This is a backport of core#20834

Notes: the PolicyScriptChecks and CheckFeeRate methods don't exist in our codebase, they are part of PreChecks. See D8203.

Test Plan:
With clang and debug:
ninja all check-all

With clang and TSAN:
ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11767

Details

Provenance
gzhao408 <gzhao408@berkeley.edu>Authored on Dec 30 2020, 17:57
PiRKCommitted on Jul 21 2022, 07:37
PiRKPushed on Jul 21 2022, 07:37
Reviewer
Restricted Project
Differential Revision
D11767: locks and docs in ATMP and CheckInputsFromMempoolAndCache
Parents
rABC8179d01a7004: [cmake] Double the functional test timeout when a sanitizer is enabled
Branches
Unknown
Tags
Unknown