Paths

Table of Contentst

Differential D11779

[refactor] return MempoolAcceptResult
ClosedPublic
Actions

Authored by PiRK on Jul 21 2022, 10:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC736e02387630: [refactor] return MempoolAcceptResult

Summary

This creates a cleaner interface with ATMP, allows us to make results const,
and makes accessing values that don't make sense (e.g. fee when tx is
invalid) an error.

This is a backport of core#21062 [2/4]
https://github.com/bitcoin/bitcoin/pull/21062/commits/f82baf0762f60c2ca5ffc339b095f9271d7c2f33

Note: changes related to RBF are not applicable

Depends on D11778

Test Plan

ninja all check-all bitcoin-bench

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 21 2022, 10:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2022, 10:05

PiRK requested review of this revision.Jul 21 2022, 10:05

teamcity edited the summary of this revision. (Show Details)Jul 21 2022, 10:06

PiRK added a child revision: D11780: [refactor] const ATMPArgs and non-const Workspace.Jul 21 2022, 10:07

PiRK edited the test plan for this revision. (Show Details)Jul 21 2022, 10:09

Harbormaster completed remote builds in B19684: Diff 34449.Jul 21 2022, 10:24

@bot build-fuzzer

teamcity awarded a token.Jul 21 2022, 19:29

Fabien accepted this revision.Jul 21 2022, 19:52

This revision is now accepted and ready to land.Jul 21 2022, 19:52

Closed by commit rABC736e02387630: [refactor] return MempoolAcceptResult (authored by gzhao408 <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhyJul 22 2022, 06:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC736e02387630: [refactor] return MempoolAcceptResult.

Revision Contents
Changeset List

Path

Size

src/

bench/

block_assemble.cpp

8 lines

net_processing.cpp

17 lines

node/

transaction.cpp

26 lines

rpc/

rawtransaction.cpp

18 lines

test/

txvalidation_tests.cpp

18 lines

txvalidationcache_tests.cpp

6 lines

validation_block_tests.cpp

12 lines

txmempool.cpp

6 lines

validation.h

52 lines

validation.cpp

66 lines

Diff 34465

View Options

src/bench/block_assemble.cpp

View Options

src/net_processing.cpp

View Options

src/node/transaction.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/txvalidation_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

[refactor] return MempoolAcceptResultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34465

src/bench/block_assemble.cpp

src/net_processing.cpp

src/node/transaction.cpp

src/rpc/rawtransaction.cpp

src/test/txvalidation_tests.cpp

src/test/txvalidationcache_tests.cpp

src/test/validation_block_tests.cpp

src/txmempool.cpp

src/validation.h

src/validation.cpp

[refactor] return MempoolAcceptResult
ClosedPublic
Actions

Revision Contents
Changeset List