Differential D11802

[avalanche] Return all the status in getrawavalancheproof RPC
ClosedPublic
Actions

Authored by Fabien on Jul 26 2022, 12:31.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC43ee3ad898fd: [avalanche] Return all the status in getrawavalancheproof RPC

Summary

This will make debugging and testing more convenient.
The "finalized: true" case is covered in the abc_p2p_avalanche_proof_voting test, so I didn't duplicate the rpc test to keep it simple.

Depends on D11808.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_getrawavalancheproof_extension

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19723
Build 39165: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 39164: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 26 2022, 12:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 26 2022, 12:31

Fabien requested review of this revision.Jul 26 2022, 12:31

Harbormaster completed remote builds in B19723: Diff 34514.Jul 26 2022, 12:49

sdulfari requested changes to this revision.Jul 26 2022, 19:08

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

test/functional/abc_p2p_avalanche_proof_voting.py
463	Can you check that the error message is indeed due to proof not existing?
468	Setting the assert_debug_log timeout is unnecessary. wait_until will determine the actual timeout time.
test/functional/test_framework/avatools.py
156	This change is best done as a separate patch.

This revision now requires changes to proceed.Jul 26 2022, 19:08

sdulfari mentioned this in D11801: [avalanche] Fix multiple flakiness issues in abc_p2p_avalanche_proof_voting.Jul 26 2022, 19:08

Rebase on top of D11808, split out the wait_for_proof refactor

Fabien edited the summary of this revision. (Show Details)Jul 27 2022, 08:50

Fabien added a parent revision: D11808: [avalanche] Fix flakiness in the stale vote functional test.

Fabien edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B19733: Diff 34526.Jul 27 2022, 09:07

Fabien added a child revision: D11809: [avalanche] Simplify the wait_for_proof test facility.Jul 27 2022, 09:44

sdulfari accepted this revision.Jul 27 2022, 17:51

This revision is now accepted and ready to land.Jul 27 2022, 17:51

Closed by commit rABC43ee3ad898fd: [avalanche] Return all the status in getrawavalancheproof RPC (authored by Fabien). · Explain WhyJul 27 2022, 19:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC43ee3ad898fd: [avalanche] Return all the status in getrawavalancheproof RPC.

sdulfari mentioned this in D11814: [avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo.Jul 28 2022, 16:58

sdulfari mentioned this in rABCc948c127e1e9: [avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo.Jul 29 2022, 18:44

Revision Contents
Changeset List

Path

Size

src/

rpc/

22 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

49 lines

abc_p2p_proof_inventory.py

4 lines

abc_rpc_avalancheproof.py

36 lines

p2p_inv_download.py

2 lines

test_framework/

20 lines

Diff 34514

src/rpc/avalanche.cpp

Loading...

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...

test/functional/abc_p2p_proof_inventory.py

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...

test/functional/p2p_inv_download.py

Loading...

test/functional/test_framework/avatools.py

Loading...