Page MenuHomePhabricator

[avalanche] Return all the status in getrawavalancheproof RPC
ClosedPublic

Authored by Fabien on Jul 26 2022, 12:31.

Details

Summary

This will make debugging and testing more convenient.
The "finalized: true" case is covered in the abc_p2p_avalanche_proof_voting test, so I didn't duplicate the rpc test to keep it simple.

Depends on D11808.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_getrawavalancheproof_extension
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19723
Build 39165: Build Difflint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 39164: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jul 26 2022, 12:31
sdulfari requested changes to this revision.Jul 26 2022, 19:08
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
test/functional/abc_p2p_avalanche_proof_voting.py
463

Can you check that the error message is indeed due to proof not existing?

468

Setting the assert_debug_log timeout is unnecessary. wait_until will determine the actual timeout time.

test/functional/test_framework/avatools.py
156

This change is best done as a separate patch.

This revision now requires changes to proceed.Jul 26 2022, 19:08

Rebase on top of D11808, split out the wait_for_proof refactor

Fabien edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jul 27 2022, 17:51