There is a couple places where the test loops over mockscheduler and waits for an event. However it might occur that the mockscheduler RPC call is exectuted before the process is being rescheduled, which makes it a no op and fails the test.
Since the loops are arbitrary in this test and do not increase coverage, this diff gets rid of the potential issue by removing them. This has the added benefit of speeding up the test slightly.
Details
Details
- Reviewers
sdulfari - Group Reviewers
Restricted Project - Commits
- rABC0200c85a88aa: [avalanche] Fix flaky loops in abc_p2p_compactproofs
for i in {1..20}; do ./test/functional/test_runner.py abc_p2p_compactproofs || break; doneDiff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche_fix_flaky_compactproofs
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19755 Build 39229: Build Diff build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 39228: arc lint + arc unit