[tests] Make p2p-leaktests.py more robust
ClosedPublic
Actions

Authored by deadalnix on Mar 7 2018, 15:09.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4ffc9140a8a4: [tests] Make p2p-leaktests.py more robust
rABC4ffc9140a8a4: [tests] Make p2p-leaktests.py more robust

Summary

Also throw in various nits.

Backport Core PR #11078: [tests] Make p2p-leaktests.py more robust

0063d2c3d [tests] Make p2p-leaktests.py more robust (John Newbery)

Pull request description:

There has been an example of p2p-leaktests.py failing on travis in the new service bits test (introduced in #11001 . It appeared to me that the previous p2p connections had not been fully disconnected before attempting to add new p2p connections.

I've added a sleep and restarted the NetworkThread, but I don't know whether this will fix the problem, since I'm unable to reproduce the failure locally.

Test Plan

./test/functional/test_runner.py p2p-leaktests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Mar 7 2018, 15:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2018, 15:09

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2021: Diff 3117.Mar 7 2018, 15:32

schancel accepted this revision.Mar 7 2018, 19:02

schancel edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Mar 7 2018, 19:02

Closed by commit rABC4ffc9140a8a4: [tests] Make p2p-leaktests.py more robust (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMar 7 2018, 21:19

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p-leaktests.py

36 lines

test_framework/

mininode.py

1 line

Diff 3124

View Options

test/functional/p2p-leaktests.py