Page MenuHomePhabricator

[tests] Make p2p-leaktests.py more robust
ClosedPublic

Authored by deadalnix on Mar 7 2018, 15:09.

Details

Summary

Also throw in various nits.

Backport Core PR #11078: [tests] Make p2p-leaktests.py more robust

0063d2c3d [tests] Make p2p-leaktests.py more robust (John Newbery)

Pull request description:

There has been an example of p2p-leaktests.py failing on travis in the new service bits test (introduced in #11001 . It appeared to me that the previous p2p connections had not been fully disconnected before attempting to add new p2p connections.

I've added a sleep and restarted the NetworkThread, but I don't know whether this will fix the problem, since I'm unable to reproduce the failure locally.
Test Plan
./test/functional/test_runner.py p2p-leaktests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
onenetthread
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2021
Build 2190: Bitcoin ABC Buildbot (legacy)
Build 2189: arc lint + arc unit