Page MenuHomePhabricator

[avalanche] Fix abc_p2p_getavaaddr flakiness
ClosedPublic

Authored by Fabien on Aug 8 2022, 14:04.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCd1356c9f2cf2: [avalanche] Fix abc_p2p_getavaaddr flakiness
Summary

The tests case that is checking for single peer request after the quorum is established can be wrong if the peers are slow enough to respond, which would cause a missing node condition during the polls and trigger a request to all our peers instead of the one. This diff fixes this by waiting for the poll to complete and run a dummy round before the actual test.

Test Plan
./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_fix_getavaaddr_test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19786
Build 39286: Build Diffbuild-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 39285: arc lint + arc unit