Page MenuHomePhabricator

[avalanche] Fix getavaaddr on OSX
ClosedPublic

Authored by Fabien on Aug 9 2022, 14:24.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC29c1db3c43a4: [avalanche] Fix getavaaddr on OSX
Summary

The OSX machine us very slow on CI and exhibited a couple additional
flakiness in the test:

  • The block generation in the wait_until loop might be repeated so many times that halving occurs and cause the latter test to fail to reach a quorum due to not enough stakes.
  • The improvements from D11834 were not enough to guarantee a 100% success rate on super slow machines, so we are using a double loop to wait for the expected event and fix this issue.
Test Plan

On OSX and Linux:

./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_getavaaddr_osx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19791
Build 39296: Build Diffbuild-debug · build-diff · build-without-wallet · build-clang · build-clang-tidy
Build 39295: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Aug 9 2022, 14:24
This revision is now accepted and ready to land.Aug 9 2022, 16:06
This revision was automatically updated to reflect the committed changes.