Paths

Table of Contentst

Differential D11850

[Cashtab] [p1 rename smallestDenomination] Rename fromSmallestDenomination to fromSatoshisToXec
ClosedPublic
Actions

Authored by bytesofman on Aug 12 2022, 16:27.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABCcdc24687d853: [Cashtab] [p1 rename smallestDenomination] Rename fromSmallestDenomination to…

Summary

T2605

part 1 of stacked diff to rename fromSmallestDenomination and toSmallestDenomination functions

Renames fromSmallestDenomination to fromSatoshisToXec

Test Plan

npm test
grep -r 'fromSmallestDenomination' src/ and verify no output

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rename-smallestdenomination-fns

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19809
Build 39332: Build Diff	cashtab-tests
Build 39331: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 12 2022, 16:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2022, 16:27

bytesofman requested review of this revision.Aug 12 2022, 16:27

Harbormaster completed remote builds in B19809: Diff 34640.Aug 12 2022, 16:30

bytesofman added a child revision: D11851: [Cashtab] [p2 rename smallestDenomination] Rename toSmallestDenomination to fromXecToSatoshis.Aug 12 2022, 16:32

kieran709 accepted this revision.Aug 16 2022, 22:56

This revision is now accepted and ready to land.Aug 16 2022, 22:56

Closed by commit rABCcdc24687d853: [Cashtab] [p1 rename smallestDenomination] Rename fromSmallestDenomination to… (authored by bytesofman). · Explain WhyAug 18 2022, 15:56

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCcdc24687d853: [Cashtab] [p1 rename smallestDenomination] Rename fromSmallestDenomination to….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Airdrop/

Airdrop.js

8 lines

Send/

Send.js

6 lines

Tokens/

Tokens.js

9 lines

hooks/

__mocks__/

sendBCH.js

4 lines

__tests__/

migrations.test.js

21 lines

useBCH.test.js

6 lines

useBCH.js

10 lines

utils/

__tests__/

16 lines

20 lines

8 lines

10 lines

Diff 34640

View Options

web/cashtab/src/components/Airdrop/Airdrop.js

View Options

web/cashtab/src/components/Send/Send.js

View Options

web/cashtab/src/components/Tokens/Tokens.js

View Options

web/cashtab/src/hooks/mocks/sendBCH.js

View Options

web/cashtab/src/hooks/tests/migrations.test.js

View Options

web/cashtab/src/hooks/tests/useBCH.test.js

View Options

web/cashtab/src/hooks/useBCH.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/tests/validation.test.js

View Options

web/cashtab/src/utils/cashMethods.js

View Options

web/cashtab/src/utils/validation.js

[Cashtab] [p1 rename smallestDenomination] Rename fromSmallestDenomination to fromSatoshisToXecClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34640

web/cashtab/src/components/Airdrop/Airdrop.js

web/cashtab/src/components/Send/Send.js

web/cashtab/src/components/Tokens/Tokens.js

web/cashtab/src/hooks/__mocks__/sendBCH.js

web/cashtab/src/hooks/__tests__/migrations.test.js

web/cashtab/src/hooks/__tests__/useBCH.test.js

web/cashtab/src/hooks/useBCH.js

web/cashtab/src/utils/__tests__/cashMethods.test.js

web/cashtab/src/utils/__tests__/validation.test.js

web/cashtab/src/utils/cashMethods.js

web/cashtab/src/utils/validation.js

[Cashtab] [p1 rename smallestDenomination] Rename fromSmallestDenomination to fromSatoshisToXec
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/hooks/mocks/sendBCH.js

web/cashtab/src/hooks/tests/migrations.test.js

web/cashtab/src/hooks/tests/useBCH.test.js

web/cashtab/src/utils/tests/cashMethods.test.js

web/cashtab/src/utils/tests/validation.test.js