Paths

Table of Contentst

Differential D11875

[Cashtab] Match return type in unit conversion functions
ClosedPublic
Actions

Authored by bytesofman on Aug 18 2022, 16:42.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABCe677025c4d76: [Cashtab] Match return type in unit conversion functions

Summary

T2604

For artifact reasons, one conversion function returns a number while the other returns BigNumber

They should both return BigNumber

Test Plan

npm test

npm start and test some transactions

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Aug 18 2022, 16:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 18 2022, 16:42

bytesofman requested review of this revision.Aug 18 2022, 16:42

Harbormaster completed remote builds in B19854: Diff 34709.Aug 18 2022, 16:45

bytesofman added a child revision: D11876: [Cashtab] Convert `balance` to string throughout app.Aug 18 2022, 21:53

kieran709 accepted this revision.Aug 22 2022, 23:03

This revision is now accepted and ready to land.Aug 22 2022, 23:03

Closed by commit rABCe677025c4d76: [Cashtab] Match return type in unit conversion functions (authored by bytesofman). · Explain WhyAug 22 2022, 23:41

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCe677025c4d76: [Cashtab] Match return type in unit conversion functions.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Airdrop/

Airdrop.js

9 lines

Send/

Send.js

4 lines

hooks/

__tests__/

migrations.test.js

16 lines

utils/

__tests__/

cashMethods.test.js

20 lines

cashMethods.js

4 lines

validation.js

7 lines

Diff 34726

View Options

web/cashtab/src/components/Airdrop/Airdrop.js

View Options

web/cashtab/src/components/Send/Send.js

View Options

web/cashtab/src/hooks/tests/migrations.test.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/cashMethods.js

View Options

web/cashtab/src/utils/validation.js

[Cashtab] Match return type in unit conversion functionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34726

web/cashtab/src/components/Airdrop/Airdrop.js

web/cashtab/src/components/Send/Send.js

web/cashtab/src/hooks/__tests__/migrations.test.js

web/cashtab/src/utils/__tests__/cashMethods.test.js

web/cashtab/src/utils/cashMethods.js

web/cashtab/src/utils/validation.js

[Cashtab] Match return type in unit conversion functions
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/hooks/tests/migrations.test.js

web/cashtab/src/utils/tests/cashMethods.test.js