Page MenuHomePhabricator
Differential D11908

[linter] Move the clang format config file to the root so it applies to chronik cpp as well
ClosedPublic
Actions

Authored by Fabien on Sep 2 2022, 13:17.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABC7bd41b784e2f: [linter] Move the clang format config file to the root so it applies to chronik…
Summary

There is no way to tell clang-format to use a specific config file before version 14, so it needs to be in a parent directory to apply to chronik.

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 2 2022, 13:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2022, 13:17
Fabien requested review of this revision.Sep 2 2022, 13:17
Harbormaster completed remote builds in B19919: Diff 34802.Sep 2 2022, 13:34
tobias_ruck accepted this revision.Sep 2 2022, 13:37
This revision is now accepted and ready to land.Sep 2 2022, 13:37
tobias_ruck added a child revision: D11909: [Chronik] Refactor bridge: Split into `chronik-bridge` and `chronik-lib`.Sep 2 2022, 13:52
Fabien updated this revision to Diff 34804.Sep 2 2022, 13:55

Fix the dead link in the developer notes

Fabien retitled this revision from [linter] Move the clang format config files to the root so it applies to chronik cpp as well to [linter] Move the clang format config file to the root so it applies to chronik cpp as well.Sep 2 2022, 14:09
Harbormaster completed remote builds in B19921: Diff 34804.Sep 2 2022, 14:13
Closed by commit rABC7bd41b784e2f: [linter] Move the clang format config file to the root so it applies to chronik… (authored by Fabien). · Explain WhySep 2 2022, 14:14
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7bd41b784e2f: [linter] Move the clang format config file to the root so it applies to chronik….

Revision Contents
Changeset List

PathSize
src/
chronik/
chronik-cpp/
6 lines
4 lines
doc/
2 lines
src/

Diff 34809

View Options

.clang-format

Loading...
View Options

chronik/chronik-cpp/chronik.cpp

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

doc/developer-notes.md

Loading...
View Options

src/.clang-format

Loading...